Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tee switch main chain #1361

Merged
merged 4 commits into from
Oct 25, 2023
Merged

tee switch main chain #1361

merged 4 commits into from
Oct 25, 2023

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Oct 19, 2023 •
edited
Loading

This change allows the user to switch which chain to "read" responses from within Tee. The purpose in mind for this is switching from the source cluster to the target cluster during OpenSearch dual writing. More details can be found in transforms.md.

@conorbros conorbros requested a review from rukai October 19, 2023 05:53
@rukai
Copy link
Member

rukai commented Oct 24, 2023

Implementing this first as a separate webservice seems reasonable to me as it will give us a reference point of what we need when we go to implement a combined metrics/config webservice.
Shotover can issue breaking changes on 0.x releases as needed, so while we want to minimize breaking changes I think its worth it in this case.

rukai
rukai reviewed Oct 24, 2023
View reviewed changes
docs/src/transforms.md Outdated Show resolved Hide resolved
rukai
rukai reviewed Oct 24, 2023
View reviewed changes
docs/src/transforms.md Outdated Show resolved Hide resolved
rukai
rukai reviewed Oct 24, 2023
View reviewed changes
docs/src/transforms.md Outdated Show resolved Hide resolved
@conorbros conorbros force-pushed the tee-switch-main-chain branch 2 times, most recently from 68cb305 to c9bc194 Compare October 24, 2023 05:23
@conorbros conorbros force-pushed the tee-switch-main-chain branch from c9bc194 to 8fa9706 Compare October 24, 2023 06:05
rukai
rukai approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Lets land this

cjrolo
cjrolo approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@cjrolo cjrolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice one!

@rukai rukai merged commit 9e58c6d into shotover:main Oct 25, 2023
38 checks passed
@conorbros conorbros deleted the tee-switch-main-chain branch May 23, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@cjrolo cjrolo cjrolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorbros @rukai @cjrolo