Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: split lints + tests into seperate workflows #1357

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 16, 2023

This will have a few benefits:

  • Make CI "out of disk space" issues less frequent - linting and testing both produce a lot of shared artifacts but they also produce a lot of large unshared artifacts, by splitting them up across separate instances we can give each more disk space to work with. This benefit was my main motivation as I hit this issue again today.
  • Make CI cached runs complete 3 mins faster - linting has become slow recently, taking ~3mins on a cached run due to having to test every combination of compile time feature. - A very nice incidental win.
  • A linting failure does not prevent seeing test results.

Downsides are some more duplication in our CI configuration.

@rukai rukai force-pushed the split_lint_and_test_ci branch 2 times, most recently from 1311e9b to f44f803 Compare October 16, 2023 04:00
@rukai rukai force-pushed the split_lint_and_test_ci branch from f44f803 to 2f1605f Compare October 16, 2023 04:03
@rukai rukai requested a review from conorbros October 16, 2023 04:52
@rukai rukai merged commit c7baffa into shotover:main Oct 16, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants