CassandraSinkCluster: switch to dashmap #1230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll review this once I have windsock cassandra benches running on AWS, should take a few days. |
|
I did 3 bench runs for this and all 3 times the results were clearly saying this PR regressed performance. I would still like to keep this PR open until I can resolve the benching noise so I can use verifying the performance of this PR as a goal to get windsock working properly. |
|
Thanks, interesting results. |
conorbros
force-pushed
the
cassandrasinkcluster-dashmap
branch
from
e4f3c02 to
54de1b0
Compare
conorbros
force-pushed
the
cassandrasinkcluster-dashmap
branch
from
54de1b0 to
2aed152
Compare
|
I checked this again, it's still a clear regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the benchmarks too noisy to determine if this actually results in a speedup but it's reasonable to assume it does at least make it a bit faster. And since we brought in the dep for Kafka sink cluster might as well use it here.