chain microbenchmarks: run the chains once before benching to avoid m…

…easuring init time
shotover · Jun 16, 2024 · c119a68 · c119a68
1 parent caa3453
commit c119a68
Showing 1 changed file with 21 additions and 36 deletions.
diff --git a/shotover/benches/benches/chain.rs b/shotover/benches/benches/chain.rs
@@ -39,10 +39,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 
         group.bench_function("loopback", |b| {
             b.to_async(&rt).iter_batched(
-                || BenchInput {
-                    chain: chain.build(TransformContextBuilder::new_test()),
-                    wrapper: wrapper.clone(),
-                },
+                || BenchInput::new(&chain, &wrapper),
                 BenchInput::bench,
                 BatchSize::SmallInput,
             )
@@ -58,10 +55,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 
         group.bench_function("nullsink", |b| {
             b.to_async(&rt).iter_batched(
-                || BenchInput {
-                    chain: chain.build(TransformContextBuilder::new_test()),
-                    wrapper: wrapper.clone(),
-                },
+                || BenchInput::new(&chain, &wrapper),
                 BenchInput::bench,
                 BatchSize::SmallInput,
             )
@@ -96,10 +90,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 
         group.bench_function("redis_filter", |b| {
             b.to_async(&rt).iter_batched(
-                || BenchInput {
-                    chain: chain.build(TransformContextBuilder::new_test()),
-                    wrapper: wrapper.clone(),
-                },
+                || BenchInput::new(&chain, &wrapper),
                 BenchInput::bench,
                 BatchSize::SmallInput,
             )
@@ -125,10 +116,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 
         group.bench_function("redis_cluster_ports_rewrite", |b| {
             b.to_async(&rt).iter_batched(
-                || BenchInput {
-                    chain: chain.build(TransformContextBuilder::new_test()),
-                    wrapper: wrapper.clone(),
-                },
+                || BenchInput::new(&chain, &wrapper),
                 BenchInput::bench,
                 BatchSize::SmallInput,
             )
@@ -172,10 +160,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 
         group.bench_function("cassandra_request_throttling_unparsed", |b| {
             b.to_async(&rt).iter_batched(
-                || BenchInput {
-                    chain: chain.build(TransformContextBuilder::new_test()),
-                    wrapper: wrapper.clone(),
-                },
+                || BenchInput::new(&chain, &wrapper),
                 BenchInput::bench,
                 BatchSize::SmallInput,
             )
@@ -226,10 +211,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 
         group.bench_function("cassandra_rewrite_peers_passthrough", |b| {
             b.to_async(&rt).iter_batched(
-                || BenchInput {
-                    chain: chain.build(TransformContextBuilder::new_test()),
-                    wrapper: wrapper.clone(),
-                },
+                || BenchInput::new(&chain, &wrapper),
                 BenchInput::bench,
                 BatchSize::SmallInput,
             )
@@ -272,10 +254,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 
         group.bench_function("cassandra_protect_unprotected", |b| {
             b.to_async(&rt).iter_batched(
-                || BenchInput {
-                    chain: chain.build(TransformContextBuilder::new_test()),
-                    wrapper: wrapper.clone(),
-                },
+                || BenchInput::new(&chain, &wrapper),
                 BenchInput::bench,
                 BatchSize::SmallInput,
             )
@@ -287,10 +266,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 
         group.bench_function("cassandra_protect_protected", |b| {
             b.to_async(&rt).iter_batched(
-                || BenchInput {
-                    chain: chain.build(TransformContextBuilder::new_test()),
-                    wrapper: wrapper.clone(),
-                },
+                || BenchInput::new(&chain, &wrapper),
                 BenchInput::bench,
                 BatchSize::SmallInput,
             )
@@ -322,10 +298,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 
         group.bench_function("query_counter", |b| {
             b.to_async(&rt).iter_batched(
-                || BenchInput {
-                    chain: chain.build(TransformContextBuilder::new_test()),
-                    wrapper: wrapper.clone(),
-                },
+                || BenchInput::new(&chain, &wrapper),
                 BenchInput::bench,
                 BatchSize::SmallInput,
             )
@@ -366,6 +339,18 @@ struct BenchInput<'a> {
 }
 
 impl<'a> BenchInput<'a> {
+    fn new(chain: &TransformChainBuilder, wrapper: &Wrapper<'a>) -> Self {
+        let mut chain = chain.build(TransformContextBuilder::new_test());
+
+        // Run the chain once so we are measuring the chain once its been fully initialized
+        futures::executor::block_on(chain.process_request(wrapper.clone())).unwrap();
+
+        BenchInput {
+            chain,
+            wrapper: wrapper.clone(),
+        }
+    }
+
     async fn bench(mut self) -> (Vec<Message>, TransformChain) {
         // Return both the chain itself and the response to avoid measuring the time to drop the values in the benchmark
         (