Skip to content

Commit

Permalink
Update runner and observability tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ronycsdu committed Nov 19, 2024
1 parent 8c1e206 commit 2b5540c
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
10 changes: 5 additions & 5 deletions shotover-proxy/tests/runner/observability_int_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -129,19 +129,19 @@ shotover_chain_latency_seconds{chain="redis",client_details="127.0.0.1",quantile
shotover_chain_latency_seconds{chain="redis",client_details="127.0.0.1",quantile="0.99"}
shotover_chain_latency_seconds{chain="redis",client_details="127.0.0.1",quantile="0.999"}
shotover_chain_latency_seconds{chain="redis",client_details="127.0.0.1",quantile="1"}
shotover_query_count{name="redis-chain",query="CLIENT",type="redis"}
shotover_query_count{name="redis-chain",query="GET",type="redis"}
shotover_query_count{name="redis-chain",query="SET",type="redis"}
shotover_query_count{name="redis-chain",query="CLIENT",type="valkey"}
shotover_query_count{name="redis-chain",query="GET",type="valkey"}
shotover_query_count{name="redis-chain",query="SET",type="valkey"}
"#;
assert_metrics_has_keys(expected, expected_new).await;

assert_metrics_key_value(
r#"shotover_query_count{name="redis-chain",query="GET",type="redis"}"#,
r#"shotover_query_count{name="redis-chain",query="GET",type="valkey"}"#,
"1",
)
.await;
assert_metrics_key_value(
r#"shotover_query_count{name="redis-chain",query="SET",type="redis"}"#,
r#"shotover_query_count{name="redis-chain",query="SET",type="valkey"}"#,
"2",
)
.await;
Expand Down
2 changes: 1 addition & 1 deletion shotover-proxy/tests/runner/runner_int_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ async fn test_shotover_shutdown_when_protocol_mismatch() {
Caused by:
Topology errors
Transform RedisSinkSingle requires upchain protocol to be one of [Redis] but was Cassandra
Transform RedisSinkSingle requires upchain protocol to be one of [Valkey] but was Cassandra
"#,
)])
.await;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
sources:
- Redis:
- Valkey:
name: "redis"
listen_addr: "127.0.0.1:6379"
chain:
Expand Down
2 changes: 1 addition & 1 deletion shotover-proxy/tests/test-configs/null-redis/topology.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
sources:
- Redis:
- Valkey:
name: "redis"
listen_addr: "127.0.0.1:6379"
chain:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
---
sources:
- Redis:
- Valkey:
name: "redis1"
listen_addr: "127.0.0.1:6379"
connection_limit: 3000000
chain:
- QueryTypeFilter:
DenyList: [Write]
- DebugReturner:
Redis: "42"
- Redis:
Valkey: "42"
- Valkey:
name: "redis2"
listen_addr: "127.0.0.1:6380"
connection_limit: 3000000
chain:
- QueryTypeFilter:
AllowList: [Read]
- DebugReturner:
Redis: "42"
Valkey: "42"

0 comments on commit 2b5540c

Please sign in to comment.