KafkaSinkCluster: Error on AlterReplicaLogDirs (#1837)

shotover · Nov 26, 2024 · 13d8842 · 13d8842
1 parent a6a4b1c
commit 13d8842
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/shotover/src/transforms/kafka/sink_cluster/mod.rs b/shotover/src/transforms/kafka/sink_cluster/mod.rs
@@ -1128,6 +1128,18 @@ Shotover cannot handle this request as it is not appropriate for shotover to shu
 The connection to the client has been closed."
                     ));
                 }
+                Some(Frame::Kafka(KafkaFrame::Request {
+                    body: RequestBody::AlterReplicaLogDirs(_),
+                    ..
+                })) => {
+                    return Err(anyhow!(
+                        "Client sent AlterReplicaLogDirs request.
+Shotover has not implemented support for this message type.
+It could theoretically be supported by performing the inverse of DescribeLogDirs.
+i.e. Define a custom path format like `actual-kafka-broker-id3:/original/log/dir/path` and then parse the broker id and send the original path to that broker.
+But it is expected that if you are using shotover as a proxy you do not care about the internal state of the kafka cluster enough to use AlterReplicaLogDirs."
+                    ));
+                }
                 Some(Frame::Kafka(KafkaFrame::Request {
                     body: RequestBody::UnregisterBroker(_),
                     ..