Update Isomer #15
Open
Update Isomer #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@itsmeduncan / @akatz - Do you two mind taking a look at this? |
| @@ -9,7 +9,7 @@ module Mulder | |||
| require_relative 'mulder/version' | |||
|
|
|||
| def self.search(app, env, role, format, config_file) | |||
| config = Mulder::Config.from(:yaml, file: config_file) | |||
| config = Isomer::Configuration.hydrate(Mulder::CONFIG, Isomer::Sources::Yaml.new(config_file)) | |||
There was a problem hiding this comment.
Here I could also add in an Environment source if we wanted to be able to load in via AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY as well as the yaml file
|
This is also not a runtime requirement so we won't be using two sources. If it works with the update version of isomer, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.