Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle more interaction types #154

Merged

Conversation

nicolas-carlier-ls
Copy link
Contributor

Convert BlockID to InteractionID field into the InteractionDefinition struct,
and add the necessary dispatch mechanisms to handle the following interactions:

  • shortcut
  • message_actions
  • view_submission
  • view_closed

  Convert BlockID to InteractionID field into the InteractionDefinition struct,
and add the necessary dispatch mechanisms to handle the following interactions:
- shortcut
- message_actions
- view_submission
- view_closed

Add Interaction type to interaction definition
@nicolas-carlier-ls nicolas-carlier-ls force-pushed the handle_interactions_differently branch from a4aa5b9 to 8ac097a Compare October 31, 2023 02:52
@raed-shomali
Copy link
Contributor

I think this looks good.

I would wait until @arusso merges #155 before you merge this as the logging interface changes slightly.

We will be using slog golang's new standard logger. So calls to the underlying logger such as Debugf will change to Debug.

Thanks for this PR!

@arusso
Copy link
Collaborator

arusso commented Nov 7, 2023

Merging this now. We can deal with the logging changes in the slog PR.

@arusso arusso merged commit fb87d90 into shomali11:master Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants