-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment (for review) #3
base: develop
Are you sure you want to change the base?
Conversation
Did that once and it got very ugly. May I fwd this to ML for wider discussion? And thank you sooo much for looking at this! You represent the first Thanks, |
I really like the way you have decoupled the frameworks. I do not actually envision the code ending up all in the same repo, just in the same namespace. It could be similar to datamapper, as an example, where you can get the whole ball of wax, or just the pieces you need. I didn't re-couple anything in this refactor, just adjusted the namespacing. I can see how it could get messy--in fact, I had thought that it wouldn't work, until I started reading your code. Having some this exercise, I do think it's possibly to use a single-rooted Shors namespace and maintain the decoupling you have established. Perhaps it's just a matter of style. Re: ML, of course, forward away! It might be helpful to get some more insights |
Eric, is this change a dependency of your subsequent pull requests? |
Peter, no, you do not need to merge this one. The other work is done within the pre-existing naming scheme. This was intended as a conversation starter :) |
I'd be ok with moving on this one. I didn't originally understand your Kindest Regards, On Thu, Apr 26, 2012 at 5:39 PM, Eric Watson <
|
At this point, I would recommend that we work on the other pull requests first, and then come back to this one. The merges will be painful if we do this one first. It won't be hard to extend this naming change out if it's what we decide to do. |
Agreed On Fri, Apr 27, 2012 at 11:18 AM, Eric Watson <
|
As a first exploration of brown shoes, I tried moving Swt into the Shoes namespace, so
SwtShoes::Button
becomesShoes::Swt::Button
and so on. Motivation: make the various flavors of Shoes feel like one integrated project (from a user perspective).vs
But mainly I'm just getting my feet wet with the code. @pjfitzgibbons what do you think?