More resilient directionality checks #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for the quick fix! |
|
we can confirm the fix is working for us. |
KonnorRogers
approved these changes
Oct 1, 2024
| @@ -259,7 +259,7 @@ export class SubmenuController implements ReactiveController { | |||
| } | |||
|
|
|||
| renderSubmenu() { | |||
| const isRtl = this.host.matches(':dir(rtl)'); | |||
| const isRtl = getComputedStyle(this.host).direction === 'rtl'; | |||
There was a problem hiding this comment.
any reason these don't do this.host.localize.dir() ?
There was a problem hiding this comment.
The localize property is private and this only occurs once when the submenu shows, so a reflow won't be problematic. We could consider exposing this.localize as public properties, but I didn't want to commit to that without a discussion first.
…o rtl-for-older-browsers
…o rtl-for-older-browsers
|
Any plans to get this released? |
|
I'll get a Shoelace release out most likely tomorrow morning. |
|
Thank you 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2188