Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IpAddressFactory from akrabat/ip-address-middleware #2277

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 22, 2024

Change to the factory provided by akrabat/ip-address-middleware package instead of using the one from shlinkio/shlink-common.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (d7e300e) to head (2946b63).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2277   +/-   ##
==========================================
  Coverage      93.68%   93.68%           
  Complexity      1655     1655           
==========================================
  Files            275      275           
  Lines           5764     5764           
==========================================
  Hits            5400     5400           
  Misses           364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@acelaya acelaya merged commit 8ee9058 into shlinkio:develop Nov 22, 2024
31 checks passed
@acelaya acelaya deleted the feature/ip-address-factory branch November 22, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant