Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure IpGeolocationMiddleware skips localhost #2272

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 19, 2024

This PR brings back some logic that was lost while migrating geolocation logic from LocateVisit event to IpGeolocationMiddleware #2266, to make sure localhost addresses resolve to an empty location rather than trying to geolocate them.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (8298ef3) to head (f57f159).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2272      +/-   ##
=============================================
+ Coverage      93.66%   93.70%   +0.03%     
+ Complexity      1658     1657       -1     
=============================================
  Files            274      274              
  Lines           5780     5780              
=============================================
+ Hits            5414     5416       +2     
+ Misses           366      364       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@acelaya acelaya merged commit c323bfc into shlinkio:develop Nov 19, 2024
31 checks passed
@acelaya acelaya deleted the feature/geolocate-localhost-fix branch November 19, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant