Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow pipelines to continue on error #2269

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 17, 2024

The project has been properly working with PHP 8.4 for a while, so let's remove continue-on-error: ${{ matrix.php-version == '8.4' }} from all workflows.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (178a99b) to head (a9ae4a2).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2269   +/-   ##
==========================================
  Coverage      93.66%   93.66%           
  Complexity      1654     1654           
==========================================
  Files            272      272           
  Lines           5774     5774           
==========================================
  Hits            5408     5408           
  Misses           366      366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 0839443 into shlinkio:develop Nov 17, 2024
31 checks passed
@acelaya acelaya deleted the feature/no-php-8.4-error branch November 17, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant