Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate IpAddressMiddlewareFactory #160

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 22, 2024

The akrabat/ip-address-middleware package includes its own factory, so we can deprecate custom one.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cdfd84e) to head (ad2fa11).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #160   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       192       192           
===========================================
  Files             51        51           
  Lines            611       611           
===========================================
  Hits             611       611           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@acelaya acelaya merged commit abdad29 into shlinkio:main Nov 22, 2024
8 checks passed
@acelaya acelaya deleted the feature/deprecate-factory branch November 22, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant