Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MercureOptions via inline factory instead of ValinorConfigFactory #154

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Oct 24, 2024

No description provided.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ad564a2) to head (0ee3ea4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #154   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       192       192           
===========================================
  Files             50        50           
  Lines            610       610           
===========================================
  Hits             610       610           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 16d19b7 into shlinkio:main Oct 24, 2024
9 checks passed
@acelaya acelaya deleted the feature/remove-valinor-factory branch October 24, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant