fix typo

shiyiya · Apr 16, 2024 · 4e766bb · 4e766bb
1 parent afbaba1
commit 4e766bb
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 12 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@oplayer/core",
-  "version": "1.2.34-beta.1",
+  "version": "1.2.34-beta.2",
   "description": "Oh! Another HTML5 video player.",
   "type": "module",
   "main": "./dist/index.es.js",

diff --git a/packages/core/src/player.ts b/packages/core/src/player.ts
@@ -428,10 +428,10 @@ export class Player<Context extends Record<string, any> = Record<string, any>> {
 
       let finalSource: Source
 
-      const errorHandler = (e: any) => {
+      const errorHandler = (err: any) => {
         if (!this.$root) return
         this.off(canplay, canplayHandler)
-        this.emit(options.brokenEvent, finalSource || sourceLike)
+        this.emit(options.brokenEvent, { source: finalSource || sourceLike, error: err })
         if (options.event == 'videosourcechanged') {
           this.isSourceChanging = false
         } else {
@@ -441,7 +441,7 @@ export class Player<Context extends Record<string, any> = Record<string, any>> {
               this.isSourceChanging = false
             })
         }
-        reject(e)
+        reject(err)
       }
 
       const rollback = () => {

diff --git a/packages/docs/public/oplayer.html b/packages/docs/public/oplayer.html
@@ -207,8 +207,8 @@
   <body>
     <div id="oplayer"></div>
 
-    <script src="https://cdn.jsdelivr.net/npm/@oplayer/[email protected].1/dist/index.min.js"></script>
-    <script src="https://cdn.jsdelivr.net/npm/@oplayer/[email protected].3/dist/index.min.js"></script>
+    <script src="https://cdn.jsdelivr.net/npm/@oplayer/[email protected].2/dist/index.min.js"></script>
+    <script src="https://cdn.jsdelivr.net/npm/@oplayer/[email protected].4/dist/index.min.js"></script>
 
     <script src="https://cdn.jsdelivr.net/npm/@oplayer/[email protected]/dist/index.min.js"></script>
     <script src="https://cdn.jsdelivr.net/npm/@oplayer/[email protected]/dist/index.min.js"></script>
@@ -302,7 +302,7 @@
               builder({
                 ...e,
                 message:
-                  (e.message ? `${e.message}\n\n` : `ErrorCode: ${e.code}\n\n`) +
+                  (e.message ? `${e.message}\n\n` : `${e.code ? `ErrorCode:${e.code} \n\n` : ''}`) +
                   'Open an issues https://github.com/shiyiya/oplayer/issues/new/choose'
               })
             },

diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@oplayer/ui",
-  "version": "1.3.0-beta.3",
+  "version": "1.3.0-beta.4",
   "description": "ui plugin for oplayer",
   "type": "module",
   "main": "./dist/index.es.js",

diff --git a/packages/ui/src/components/ControllerBar.ts b/packages/ui/src/components/ControllerBar.ts
@@ -104,10 +104,12 @@ const render = (it: UIInterface, el: HTMLDivElement) => {
   player.on('videosourcechange', ({ payload }) => {
     if (!payload.then) {
       $controlBarTitle.innerText = payload.title || ''
-    } else {
-      player.once('sourcechangeerror', () => {
-        $controlBarTitle.innerText = 'ERROR'
-      })
+    }
+  })
+
+  player.on('sourcechangeerror', ({ payload }) => {
+    if (!payload.source?.title) {
+      $controlBarTitle.innerText = (payload.e as Error)?.message || 'ERROR'
     }
   })