Fix for Rails 8 query issue breaks select with no order clause

[shioyama]

#655 fixed an issue with failing querying tests in AR 8, but as it turns out test coverage was incomplete and the fix has introduced breakage to select when used without order.

I added a small expectation which removes the order on part of existing querying tests, and tests now fail on master. Removing the fix from #655, they pass (but others fail on AR 8).

The change in Rails was this commit: rails/rails@ba468db

cc @jukra @n-rodriguez

We now have a broken state on master.

[shioyama]

This fails with the query.order_values.any? check, but passes with it removed.

[n-rodriguez]

With the patch :

SELECT "article_translations_en"."title" FROM "articles" LEFT OUTER JOIN "article_translations" "article_translations_en" ON "article_translations_en"."article_id" = "articles"."id" AND "article_translations_en"."locale" = 'en'
#<Article title: "foo", id: nil>
nil
#<Article title: "foo", id: nil>
nil
#<Article title: "bar", id: nil>
nil
#<Article title: "bar", id: nil>
nil
#<Article title: "bar", id: nil>
nil

Without the patch :

SELECT "article_translations_en"."title" AS __mobility_title_en__ FROM "articles" LEFT OUTER JOIN "article_translations" "article_translations_en" ON "article_translations_en"."article_id" = "articles"."id" AND "article_translations_en"."locale" = 'en'
#<Article __mobility_title_en__: "foo", id: nil>
"foo"
#<Article __mobility_title_en__: "foo", id: nil>
"foo"
#<Article __mobility_title_en__: "bar", id: nil>
"bar"
#<Article __mobility_title_en__: "bar", id: nil>
"bar"
#<Article __mobility_title_en__: "bar", id: nil>
"bar"

SQL :

SELECT "article_translations_en"."title"                          FROM "articles" LEFT OUTER JOIN "article_translations" "article_translations_en" ON "article_translations_en"."article_id" = "articles"."id" AND "article_translations_en"."locale" = 'en'
SELECT "article_translations_en"."title" AS __mobility_title_en__ FROM "articles" LEFT OUTER JOIN "article_translations" "article_translations_en" ON "article_translations_en"."article_id" = "articles"."id" AND "article_translations_en"."locale" = 'en'

[n-rodriguez]

Maybe related? :

rails/rails#53509
rails/rails#53514

[shioyama]

I think I have a fix which works for now, see my last commit.

[shioyama]

There should be a better way to make selects work, but for now I'm going to ship this to at least fix the immediate problem.