Fix passing unpacked options #637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The define_handler_methods method in the Mobility gem's plugin was not properly handling method invocation with additional parameters, causing issues with methods like `will_save_change_to_attribute?(from:,to:)`. This fix modifies the else block to correctly pass additional parameters to the super method, ensuring proper functionality.
|
Can you rebase (I fixed some failing sequel tests) and add a failing test to show what you are fixing? |
shioyama
reviewed
Mar 26, 2024
| @@ -142,7 +142,8 @@ def #{method_name}(attr_name, *rest#{kwargs}) | |||
| mutations_from_mobility.attribute_previously_changed?(attr_name)) | |||
| mutations_from_mobility.send(#{method_name.inspect}, attr_name, *rest#{kwargs}) | |||
| else | |||
| super | |||
| options = rest.first || {} | |||
| super(attr_name, **options) | |||
There was a problem hiding this comment.
Hmm, this doesn't look right. There is already some code handling keyword arguments above. Are you sure this fixes the issue? Please add a failing test.
|
I got something similar with |
|
I think I got it fixed correctly in #639. |
|
Merged @doits's fix and shipped as 1.3.0.rc3, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The define_handler_methods method in the Mobility gem's plugin was not properly handling method invocation with additional parameters, causing issues with methods like
will_save_change_to_attribute?(from:,to:). This fix modifies the else block to correctly pass additional parameters to the super method, ensuring proper functionality.