Don't try to load generators if Rails is loaded but ActiveRecord is not. #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generators are dependent on ActiveRecord, so if you are using rails without active_record, mobility would not load : ``` `require': cannot load such file -- rails/generators/active_record (LoadError) ```
|
Can you rebase this on master? Should be green then. |
|
I cherry-picked the first commit but not the dirty accessors one, thanks! ❤️ |
|
Thanks. Sorry for the second commit.. It was added automatically when I was trying to fix something else. I should have created a specific branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generators are implicitly dependent on ActiveRecord, so if you are using Rails and you are not using ActiveRecord (We use Sequel with Rails), mobility would not load correctly and we would get the following error :
This patch explicitly check that ActiveRecord is loaded before requiring the generators.