Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

「続きを読み込む」ボタンを横広に #689

Merged
merged 2 commits into from
Nov 17, 2024
Merged

「続きを読み込む」ボタンを横広に #689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcc1bd6
「続きを読み込む」ボタンを横広に
Npepperlinux Nov 16, 2024
e3c3373
テストの修正
Npepperlinux Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lib/view/common/pushable_listview.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,12 @@ class PushableListView<T> extends HookConsumerWidget {
const SizedBox.shrink(),
],
),
Center(
child: Padding(
padding: const EdgeInsets.only(top: 10, bottom: 10),
child: IconButton(
onPressed: nextLoad,
icon: const Icon(Icons.keyboard_arrow_down),
),
InkWell(
onTap: nextLoad,
child: Container(
alignment: Alignment.center,
height: 60,
child: const Icon(Icons.keyboard_arrow_down),
),
),
],
Expand Down
11 changes: 8 additions & 3 deletions lib/view/time_line_page/misskey_time_line.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,14 @@ class MisskeyTimeline extends HookConsumerWidget {
}

return Center(
child: IconButton(
onPressed: downDirectionLoad,
icon: const Icon(Icons.keyboard_arrow_down),
child: InkWell(
onTap: downDirectionLoad,
child: Container(
alignment: Alignment.center,
constraints: const BoxConstraints(maxWidth: 800),
height: 60,
child: const Icon(Icons.keyboard_arrow_down),
),
),
);
}
Expand Down
4 changes: 2 additions & 2 deletions test/test_util/widget_tester_extension.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ extension WidgetTestExtension on WidgetTester {
await tap(
find.descendant(
of: find.descendant(
of: find.byType(Center),
matching: find.byType(IconButton).hitTestable(),
of: find.byType(InkWell),
matching: find.byType(Container).hitTestable(),
),
matching: find.byIcon(Icons.keyboard_arrow_down),
),
Expand Down