Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 簡易ノート投稿欄の投稿ボタン等を変更 #590

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Npepperlinux
Copy link
Contributor

@Npepperlinux Npepperlinux commented Apr 6, 2024

Close #451

簡易投稿欄におけるボタンのアイコンを変更する提案です。

  • 投稿ボタンをedit(ペン)からsend(紙飛行機)に変更しました
    • Misskeyを始めAndroid SMSやLINEの投稿ボタンも紙飛行機アイコンが使用されていることから、統一した方がいいと思います
  • ノート編集ページへのボタンをkeyboard_arrow_right(右矢印)からedit_note(ノートを編集)に変更しました
    • 投稿ボタンを紙飛行機に変更したことでボタンの存在が認識しにくくなってしまったため、「編集の意味を持つもの」「ペン以外のもの(投稿ボタンとして捉えられる可能性があるため)」に変更しました
  • 簡易投稿欄の左右に間隔を開けるように変更しました →このPRでやる必要はないので削除
変更前 変更後
Screenshot from 2024-04-06 14-11-06 Screenshot from 2024-04-06 14-07-04

Note

アイコンの変更は、現在利用中のユーザーが混乱する可能性があります。

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.69%. Comparing base (6955662) to head (79b9786).
Report is 1 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #590   +/-   ##
========================================
  Coverage    27.69%   27.69%           
========================================
  Files          312      312           
  Lines        16253    16253           
========================================
  Hits          4501     4501           
  Misses       11752    11752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Npepperlinux Npepperlinux force-pushed the fix/send_icon_was_pencil branch from fa92e9f to 1f4c745 Compare April 13, 2024 02:52
@Npepperlinux Npepperlinux force-pushed the fix/send_icon_was_pencil branch from 1f4c745 to 79b9786 Compare November 8, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

投稿ボタンの違和感
2 participants