[Android] アダプティブアイコンの細かな修正＆テーマ別アイコン対応 #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #583 +/- ##
===========================================
- Coverage 36.60% 36.60% -0.01%
===========================================
Files 257 257
Lines 13587 13587
===========================================
- Hits 4974 4973 -1
- Misses 8613 8614 +1 ☔ View full report in Codecov by Sentry. |
|
テーマ別アイコンで使用しているアイコンについて、現在のコミットではInkscapeによるトレース（画像左）を使用していますが、他のアプリのテーマ別アイコンとデザインを揃えるため、専用のモノクロアイコン（画像右）を使用することを提案します。
|
Npepperlinux
force-pushed
the
feat/icon_adaptive_monochrome
branch
from
99b1efe to
7064f53
Compare
shiosyakeyakini-info
merged commit cd6cdde
into
shiosyakeyakini-info:feature/miria_v2
1 check failed
|
たしかに右のほうがかわいいのでこれにします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Androidのアプリアイコンに関する変更の提案です。
icon_adaptive.pngを透過画像icon_adaptive_foreground.pngに変更し、背景色を画像から抽出した#acet602に設定する変更です。icon_adaptive_monochrome.pngを追加する提案です。icon_adaptive_foreground.pngをベースにInkscapeで「ビットマップからトレース」をした透過画像です。Related to #449 and #572 ?