Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リアクションと投票の後にnotes/showを呼ばない #427

Conversation

poppingmoon
Copy link
Contributor

Fix #426

リアクションを付けたり外したりするときにNoteRepositoryのリアクションの数や自分のリアクションを更新するようにしました
これによってリアクションの後に notes/show を呼んで情報を更新する必要がなくなったため、タイムラグがなくなりました

また、ストリーミングで二重に更新されることを防ぐために自分のリアクションであれば既に更新しているかどうかを確認してから更新するようにしました

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (d7d9ac2) 39.72% compared to head (a90f285) 39.68%.

Files Patch % Lines
lib/repository/note_repository.dart 1.81% 54 Missing ⚠️
lib/view/common/misskey_notes/misskey_note.dart 0.00% 11 Missing ⚠️
lib/view/common/misskey_notes/reaction_button.dart 0.00% 7 Missing ⚠️
lib/view/common/misskey_notes/note_vote.dart 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #427      +/-   ##
===========================================
- Coverage    39.72%   39.68%   -0.04%     
===========================================
  Files          237      237              
  Lines        11681    11701      +20     
===========================================
+ Hits          4640     4644       +4     
- Misses        7041     7057      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poppingmoon poppingmoon force-pushed the remove-reaction-delay branch from 7680029 to 212a07b Compare November 4, 2023 00:37
@poppingmoon poppingmoon changed the title リアクション後にnotes/showを呼ばない リアクションと投票の後にnotes/showを呼ばない Nov 9, 2023
@poppingmoon
Copy link
Contributor Author

ioで投票した後に反映されないことがあったので、投票の処理もリアクションと同様に変更しました

@poppingmoon poppingmoon force-pushed the remove-reaction-delay branch from 54077e8 to 1e69745 Compare November 9, 2023 20:01
@poppingmoon poppingmoon force-pushed the remove-reaction-delay branch 2 times, most recently from df83ec6 to a90f285 Compare November 19, 2023 22:17
@shiosyakeyakini-info
Copy link
Owner

これもやっぱり入れないことにしました… 

@poppingmoon poppingmoon deleted the remove-reaction-delay branch June 22, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ioで自分のリアクションの反映が遅い
3 participants