Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ドライブを追加 #418

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

poppingmoon
Copy link
Contributor

@poppingmoon poppingmoon commented Oct 23, 2023

Resolve #366
Fix #421

ドライブのフォルダとファイルの一覧を追加し、ドライブ関連の操作ができるようにしました

  • フォルダとファイルをグリッドで表示します
    • 画面の幅によって列数が変わります
  • グリッドの上に現在いるフォルダまでの階層が表示されます
    • タップしたフォルダまで戻ることができます
  • フォルダ名とファイル名の右側のアイコンをタップすると各種の操作ができます
  • フォルダをタップするとそのフォルダに入り、戻ると一つ上のフォルダに戻ります
  • ファイルをタップするとファイルの詳細ページに移ります
    • ファイル名などの情報が表示されるタブと、そのファイルを添付しているノートの一覧が表示されるタブがあります
  • ファイルを長押しするとファイルを選択します
    • 一つ以上のファイルが選択されているとき、ファイルをタップすると選択と選択解除ができます
    • 一括でダウンロード、移動、削除ができます
  • DriveFileSelectDialogをDialog の中にDrivePageを入れたものにしました
    • ファイルをタップすると選択と選択解除ができます
    • FloatingActionButtonをタップすると選択されたファイルがpopされます

shiosyakeyakini-info/misskey_dart#30 に依存します

DrivePage DriveFilePage DriveFolderSelectDialog DriveFileSelectDialog

@poppingmoon poppingmoon marked this pull request as draft October 23, 2023 23:09
@poppingmoon poppingmoon marked this pull request as ready for review October 24, 2023 10:01
@poppingmoon poppingmoon force-pushed the drive branch 6 times, most recently from 8ae5d33 to 01eceb4 Compare November 4, 2023 07:50
@poppingmoon poppingmoon force-pushed the drive branch 2 times, most recently from 23dd318 to 32bd19f Compare November 5, 2023 06:08
@poppingmoon poppingmoon force-pushed the drive branch 4 times, most recently from 6be83c7 to 190b7c7 Compare November 18, 2023 10:10
@poppingmoon poppingmoon force-pushed the drive branch 2 times, most recently from f2414d2 to a92945b Compare November 26, 2023 23:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 1.69628% with 1217 lines in your changes missing coverage. Please review.

Project coverage is 25.99%. Comparing base (8512cea) to head (c906341).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
lib/view/drive_page/drive_page.dart 0.00% 190 Missing ⚠️
lib/view/drive_page/drive_file_modal_sheet.dart 0.00% 146 Missing ⚠️
...ew/drive_page/drive_file_page/drive_file_info.dart 0.00% 132 Missing ⚠️
...ive_file_notes_page/attached_notes_notifier.g.dart 1.38% 71 Missing ⚠️
lib/view/drive_page/drive_files_modal_sheet.dart 0.00% 69 Missing ⚠️
...te_notifier/drive_page/drive_files_notifier.g.dart 1.44% 68 Missing ⚠️
..._notifier/drive_page/drive_folders_notifier.g.dart 1.44% 68 Missing ⚠️
lib/view/drive_page/drive_folder_modal_sheet.dart 0.00% 68 Missing ⚠️
...tate_notifier/drive_page/drive_files_notifier.dart 0.00% 67 Missing ⚠️
...te_notifier/drive_page/drive_folders_notifier.dart 0.00% 62 Missing ⚠️
... and 18 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #418      +/-   ##
===========================================
- Coverage    27.73%   25.99%   -1.74%     
===========================================
  Files          312      336      +24     
  Lines        16296    17427    +1131     
===========================================
+ Hits          4520     4531      +11     
- Misses       11776    12896    +1120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poppingmoon poppingmoon force-pushed the drive branch 3 times, most recently from 6a3aae7 to 9c27c32 Compare December 19, 2023 11:30
@poppingmoon poppingmoon force-pushed the drive branch 2 times, most recently from 084ac5a to 0798b32 Compare January 28, 2024 01:31
@shiosyakeyakini-info shiosyakeyakini-info changed the base branch from develop to feature/miria_v2 June 22, 2024 05:25
@poppingmoon poppingmoon changed the base branch from feature/miria_v2 to develop November 12, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drive_file_select_dialogのテキストやボタンが見えない ドライブ機能
2 participants