Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

非公開のときフォロワー数を表示しない #398

Merged
merged 2 commits into from
Jan 27, 2024
Merged

非公開のときフォロワー数を表示しない #398

merged 2 commits into from
Jan 27, 2024

Conversation

poppingmoon
Copy link
Contributor

@poppingmoon poppingmoon commented Oct 15, 2023 •
edited
Loading

Fix #397

ffVisibilityがfollowersでフォローしていないときとprivateのときにフォロー・フォロワー数を表示しないようにしました

shiosyakeyakini-info/misskey_dart#25 に依存します

表示 非表示

@poppingmoon poppingmoon force-pushed the hide-relations branch 3 times, most recently from ba97031 to 386dd62 Compare October 21, 2023 07:50
@poppingmoon poppingmoon force-pushed the hide-relations branch 3 times, most recently from e51b151 to 33e8605 Compare November 4, 2023 22:58
@poppingmoon
Copy link
Contributor Author

poppingmoon commented Nov 4, 2023 •
edited
Loading

"フォローしていない場合でフォロー申請が必要ない場合、フォローするのボタンが表示されること" のテストを削除しました

users/show で他人を指定したときのレスポンスに autoAcceptFollowed は含まれず、鍵をかけているユーザーがフォロー中のユーザーからのフォローを自動で承認するかどうか事前に知ることはできません

https://github.com/misskey-dev/misskey/blob/8372e547ebd820447aa4c6c8bd1040c51411a2aa/packages/backend/src/core/entities/UserEntityService.ts#L453

見直したら isLocked: false で autoAcceptFollowed は関係なかったので戻しました

@poppingmoon poppingmoon force-pushed the hide-relations branch 3 times, most recently from e836516 to 9a9c535 Compare November 11, 2023 00:03
@poppingmoon poppingmoon force-pushed the hide-relations branch 2 times, most recently from 40d0541 to 191a510 Compare November 26, 2023 23:20
@poppingmoon poppingmoon force-pushed the hide-relations branch 2 times, most recently from e9f5476 to 135f9e8 Compare December 4, 2023 22:25
@poppingmoon poppingmoon force-pushed the hide-relations branch 5 times, most recently from 3e7cab7 to 892c32e Compare December 22, 2023 21:53
@shiosyakeyakini-info shiosyakeyakini-info merged commit c515b00 into shiosyakeyakini-info:develop Jan 27, 2024
1 check failed
@poppingmoon poppingmoon deleted the hide-relations branch January 27, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

フォロー・フォロワー数が非公開のとき表示しない
2 participants
@poppingmoon @shiosyakeyakini-info