Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

テーマをインストールできるように #386

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

poppingmoon
Copy link
Contributor

@poppingmoon poppingmoon commented Oct 10, 2023

Resolve #383

テーマのインストールと削除ができるようにしました

  • shared preferencesにテーマコードを保存します
  • 組み込みテーマと同様にidで指定します
インストールダイアログ インストールされたテーマ一覧 テーマの選択 テーマの適用後
image image image image

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 21.05263% with 105 lines in your changes missing coverage. Please review.

Project coverage is 27.67%. Comparing base (8512cea) to head (69d0004).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...e/general_settings_page/installed_themes_page.dart 2.08% 47 Missing ⚠️
...ge/general_settings_page/install_theme_dialog.dart 2.85% 34 Missing ⚠️
...lled_themes_page/misskey_theme_codes_notifier.dart 45.45% 18 Missing ⚠️
...e/general_settings_page/general_settings_page.dart 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #386      +/-   ##
===========================================
- Coverage    27.73%   27.67%   -0.07%     
===========================================
  Files          312      316       +4     
  Lines        16296    16427     +131     
===========================================
+ Hits          4520     4546      +26     
- Misses       11776    11881     +105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poppingmoon poppingmoon force-pushed the theme-install branch 5 times, most recently from 58364ac to 92db940 Compare October 21, 2023 07:43
@poppingmoon poppingmoon force-pushed the theme-install branch 2 times, most recently from b4ec5ef to a8e9fa9 Compare October 30, 2023 20:15
@poppingmoon poppingmoon force-pushed the theme-install branch 3 times, most recently from e9a65a1 to 3efbeb0 Compare November 6, 2023 11:28
@poppingmoon poppingmoon force-pushed the theme-install branch 2 times, most recently from b600b99 to 655967d Compare November 24, 2023 16:14
@poppingmoon poppingmoon force-pushed the theme-install branch 2 times, most recently from 58c5fe1 to f081350 Compare December 3, 2023 01:14
@poppingmoon poppingmoon force-pushed the theme-install branch 2 times, most recently from 73057c9 to 26975cc Compare January 28, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

テーマのインストール
2 participants