Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リンクのプレビューを追加 #348

Merged

Conversation

poppingmoon
Copy link
Contributor

@poppingmoon poppingmoon commented Sep 29, 2023

Resolve #153

https://<host>/url?url=<target_url> が返すリンクの要約を表示します

タップすると外部ブラウザでリンクを開き、長押しするとリンクをコピーするようにしました

また、Misskey Webと同様にプレイヤーの表示とツイートの展開ができるようにしました
これにはwebview_flutterを使っています
AndroidとiOS以外では表示されません

リンク プレイヤー ツイート

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #348 (cb2cc17) into develop (81a4ae0) will decrease coverage by 0.46%.
The diff coverage is 4.46%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #348      +/-   ##
===========================================
- Coverage    27.56%   27.10%   -0.46%     
===========================================
  Files          227      232       +5     
  Lines        11120    11344     +224     
===========================================
+ Hits          3065     3075      +10     
- Misses        8055     8269     +214     
Files Coverage Δ
lib/model/summaly_result.dart 0.00% <0.00%> (ø)
lib/view/common/misskey_notes/misskey_note.dart 36.38% <45.45%> (+0.38%) ⬆️
lib/view/common/misskey_notes/twitter_embed.dart 0.00% <0.00%> (ø)
lib/model/summaly_result.g.dart 0.00% <0.00%> (ø)
lib/view/common/misskey_notes/player_embed.dart 0.00% <0.00%> (ø)
lib/view/common/misskey_notes/link_preview.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@poppingmoon
Copy link
Contributor Author

Misskey Webで表示されている画像が表示されないことがある
summalyを使ったほうがよさそう

@poppingmoon poppingmoon marked this pull request as draft September 29, 2023 23:44
@poppingmoon poppingmoon marked this pull request as ready for review September 30, 2023 02:14
@poppingmoon poppingmoon force-pushed the url-preview branch 8 times, most recently from b3ea8c3 to 329a91a Compare October 3, 2023 09:32
@poppingmoon poppingmoon force-pushed the url-preview branch 5 times, most recently from d7e8329 to bc15c8c Compare October 11, 2023 11:31
@shiosyakeyakini-info shiosyakeyakini-info merged commit d32fbf1 into shiosyakeyakini-info:develop Oct 21, 2023
1 check passed
@shiosyakeyakini-info
Copy link
Owner

何点か気になる点があった(自ホストのページやクリップを外のブラウザで開くとか、思ったより画面を占有するとか)ので、マージしてからちょっと調整しようと思います

@poppingmoon poppingmoon deleted the url-preview branch October 21, 2023 07:03
@poppingmoon
Copy link
Contributor Author

このPRに限った話ではありませんが、気になる点があれば先に指摘してもらえたほうが嬉しいです

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リンクのプレビューに対応する
3 participants