Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow credentials to be passed up to allow securing behind phoenix pipelines #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgwidmann
Copy link

The following does not work:

scope "/admin" do
  pipe_through :admin

  forward "/wobserver", Wobserver.Web.Router
end

All JSON api requests end up being denied because no cookies are sent and so therefore cannot be validated.

@coveralls
Copy link

coveralls commented Sep 20, 2017

Coverage Status

Coverage remained the same at 99.716% when pulling 5d69ac6 on mgwidmann:include_credentials into 7c6186b on shinyscorpion:master.

@mgwidmann
Copy link
Author

I'm not sure that my changes actually caused those errors, did they?

@mgwidmann
Copy link
Author

bump any thoughts on this? Its quite annoying to build this from source every time...

@mgwidmann
Copy link
Author

can we get some movement on this PR?

@langalex
Copy link

langalex commented Jan 5, 2018

looking at master, the build was already broken, so it wasn't you @mgwidmann.

@langalex
Copy link

langalex commented Jan 5, 2018

most of the breakage occurred with this "Update dependencies." commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants