a bunch of fixes #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evadne
commented
Nov 12, 2018
•
evadne
commented
- fixes claimed_id under https scheme not recognised
- fixes some users with private profiles crashing the service
- moves user retrieval after auth ticket verification to avoid unnecessary work
- moves OpenID and Steam API logic to dedicated files
- fixes use of HTTPoison in certain places
- stops converting responses to atoms
- bumps meck so tests run again on Erlang/OTP 21
- fixes claimed_id under https scheme not recognised - fixes some users with private profiles crashing the service - moves user retrieval after auth ticket verification to avoid unnecessary work - moves OpenID and Steam API logic to dedicated files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.