Skip to content

Commit

Permalink
fix(core): accept kwargs in get file
Browse files Browse the repository at this point in the history
Fixes iterative/dvc-s3#80 

It is similar to `gcsfs` and `adlfs`.

On our end it seems `max_concurrency` is passed here https://github.com/iterative/dvc-objects/blob/main/src/dvc_objects/fs/generic.py#L210 and since the new version has this attr we pass it now, which most likely leads to this error.

I'm not sure why `_gef_file` part was not yet implemented. @pmrowla might have a better idea on was it complicated, or less priority. It seems it is the natural next step to do so.
  • Loading branch information
shcheklein authored Mar 17, 2024
1 parent 1ddc2b0 commit 3697ba4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion s3fs/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -1271,7 +1271,7 @@ async def _upload_chunk(chunk, part_number):
return out

async def _get_file(
self, rpath, lpath, callback=_DEFAULT_CALLBACK, version_id=None
self, rpath, lpath, callback=_DEFAULT_CALLBACK, version_id=Nonea, **kwargs
):
if os.path.isdir(lpath):
return
Expand Down

0 comments on commit 3697ba4

Please sign in to comment.