resolved coderabbitai comments

shauryag2002 · Dec 2, 2024 · 4d0a553 · 4d0a553
1 parent 2812e9c
commit 4d0a553
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/src/Utils/request/api.tsx b/src/Utils/request/api.tsx
@@ -89,7 +89,10 @@ import {
   UserModel,
 } from "@/components/Users/models";
 
-import { PaginatedResponse } from "@/Utils/request/types";
+import {
+  DoctorPaginatedResponse,
+  PaginatedResponse,
+} from "@/Utils/request/types";
 
 /**
  * A fake function that returns an empty object casted to type T
@@ -671,7 +674,7 @@ const routes = {
 
   listDoctor: {
     path: "/api/v1/facility/{facilityId}/hospital_doctor/",
-    TRes: Type<PaginatedResponse<DoctorModal>>(),
+    TRes: Type<DoctorPaginatedResponse<DoctorModal>>(),
   },
   getDoctor: {
     path: "/api/v1/facility/{facilityId}/hospital_doctor/{id}/",

diff --git a/src/Utils/request/types.ts b/src/Utils/request/types.ts
@@ -41,5 +41,8 @@ export interface PaginatedResponse<TItem> {
   next: string | null;
   previous: string | null;
   results: TItem[];
+}
+
+export interface DoctorPaginatedResponse<T> extends PaginatedResponse<T> {
   total_doctors: number;
 }
diff --git a/src/components/Common/Pagination.tsx b/src/components/Common/Pagination.tsx
@@ -12,15 +12,15 @@ interface PaginationProps {
   defaultPerPage: number;
   cPage: number;
   className?: string;
-  ScrollToTop?: boolean;
+  scrollToTop?: boolean;
 }
 const Pagination = ({
   className = "mx-auto my-4",
   data,
   onChange,
   defaultPerPage,
   cPage,
-  ScrollToTop = true,
+  scrollToTop = true,
 }: PaginationProps) => {
   const [rowsPerPage, setRowsPerPage] = useState(3);
   const [currentPage, setCurrentPage] = useState(1);
@@ -83,7 +83,7 @@ const Pagination = ({
     setCurrentPage(page);
     onChange(page, rowsPerPage);
     const pageContainer = window.document.getElementById("pages");
-    if (ScrollToTop) {
+    if (scrollToTop) {
       pageContainer?.scroll({
         top: 0,
         left: 0,

diff --git a/src/components/Facility/FacilityStaffList.tsx b/src/components/Facility/FacilityStaffList.tsx
@@ -41,9 +41,7 @@ export const FacilityStaffList = (props: any) => {
   const handlePageChange = (page: number) => {
     updatePage(page);
     const staffCapacityElement = document.getElementById("staff_capacity");
-    if (staffCapacityElement) {
-      staffCapacityElement.scrollIntoView({ behavior: "smooth" });
-    }
+    staffCapacityElement?.scrollIntoView({ behavior: "smooth" });
   };
 
   let doctorList: any = null;
@@ -133,7 +131,7 @@ export const FacilityStaffList = (props: any) => {
         cPage={qParams.page}
         defaultPerPage={resultsPerPage}
         data={{ totalCount: doctorsList?.count ?? 0 }}
-        ScrollToTop={false}
+        scrollToTop={false}
         onChange={(page: number) => handlePageChange(page)}
       />
     </section>