Pullrequest/wedo2 #198
Merged
Pullrequest/wedo2 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthiery
reviewed
Jan 15, 2024
| { } | ||
|
|
||
| public IEnumerable<byte[]> GetStaticPortInfoMessages(Version softwareVersion, Version hardwareVersion, SystemType systemType) | ||
| // Dump taken from LEGO 6290182 - 21980 - Electric, Motor WeDo 2.0 Medium which reports as 'LPF2-MMOTOR'. |
There was a problem hiding this comment.
IMHO, the motor is not reporting that but your MediumTechnicHub describes the motor. The Lego Wireless Protocol is a Bluetooth protocol, not a wire protocol between the hub and the motor. It could though, but I am not aware of any details there.
There was a problem hiding this comment.
I am not sure, but of course we communicate with the Hub, but I think the data essentially comes from the motor and is translated and passed on by the hub, don't all motors work with all hubs? All hubs would have to know all device types then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #58
It looks like this is all the motor can do, is it correct?