Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non_snake_case diagnostic in derive::DekuRead #381

Merged
merged 1 commit into from Dec 8, 2023
Merged

Fix non_snake_case diagnostic in derive::DekuRead #381

merged 1 commit into from Dec 8, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 8, 2023

This commit:

  • Adds missing #[allow(non_snake_case)] attrs in fn read emits in derive(DekuRead);
  • Changes the field prefix in gen_internal_field_ident: __deku___ -> __deku_field_, (there's no reason for that, so I'm keeping that out of the PR)

Fixes #366 (comment).

Copy link
Owner

@sharksforarms sharksforarms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@sharksforarms sharksforarms merged commit 3ec4d10 into sharksforarms:master Dec 8, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants