-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl writer #355
Impl writer #355
Conversation
Benchmark for 54c55edClick to view benchmark
|
Benchmark for bd28774Click to view benchmark
|
Benchmark for 95f691cClick to view benchmark
|
2aaab51
to
0a75a2c
Compare
Benchmark for ed7c8e1Click to view benchmark
|
Benchmark for 699a870Click to view benchmark
|
e0f8089
to
19ee687
Compare
9e6aca1
to
bf6defb
Compare
2450cf4
to
dfbbc30
Compare
Benchmark for 3e9011cClick to view benchmark
|
Benchmark for eb2f763Click to view benchmark
|
Benchmark for 91bbf94Click to view benchmark
|
Benchmark for 28f76c8Click to view benchmark
|
b1d27e4
to
98eea78
Compare
Benchmark for ada4d93Click to view benchmark
|
Benchmark for 64901e4Click to view benchmark
|
Benchmark for b1956c2Click to view benchmark
|
Benchmark for f60fb68Click to view benchmark
|
b32ef5d
to
934b42c
Compare
1d23236
to
c0f9fd4
Compare
c300f40
to
91bb702
Compare
Benchmark for aa9c730Click to view benchmark
|
@wcampbell0x2a ack. I may not get to review it until the new year |
Butterfingers closing the mr 😂 No problem! I also might bike-shed the names back to |
Benchmark for e323734Click to view benchmark
|
9af390b
to
157add8
Compare
Benchmark for 47f4940Click to view benchmark
|
157add8
to
7297dc4
Compare
Benchmark for 17ab8fcClick to view benchmark
|
7297dc4
to
26c00d3
Compare
Benchmark for 8ff18c4Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! I left a couple of minor comments/questions. Very exciting for this to land with the reader changes + performance improvements, thanks for your persistent efforts here
Benchmark for 6ce10f9Click to view benchmark
|
c0b837c
to
0ada1dc
Compare
Benchmark for 3d39323Click to view benchmark
|
Benchmark for 4a4679cClick to view benchmark
|
* Update to syn 2.0, darling 0.20 - Change `type` for enums into `id_type`, as this is no longer accepted through the syn parser library * Update to rstest 0.18
- Reduce codegen by making this a default impl
16aef36
to
3bb6e31
Compare
Benchmark for 6633da3Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, this looks great.
Implement faster writing for bytes and support for
Write
. At the expense of some performance for only bit-wise writing.Tested
Create Issue
&[u8]
andVec<u8>
so that results directly to one invocation ofwriter.write_bytes(..)
instead of 1 byte per len. This is only possible forCtx = ()
?See wcampbell0x2a/deku-bench#6 (that uses #393)