Skip to content

Commit

Permalink
Fix ArgoCD certificate issue
Browse files Browse the repository at this point in the history
Upgrade argo cd chart
  • Loading branch information
voatsap authored Mar 24, 2020
2 parents f3e14f4 + 25f77e8 commit 2a183ff
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 9 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ You receive:
1. Dedicate a separate repository for the infrastructure that will be managed by `cluster.dev`. This repo will host code for your clusters, deployments and other resources managed by GitOps.
Next steps should be done in that repo.

2. Obtain access credentials for your cloud account.
2. Obtain access credentials for your cloud account.
For example, in AWS it is called "Programmatic Access user", and looks like:

```yaml
Expand All @@ -53,7 +53,8 @@ cluster:
provider: aws
region: eu-central-1
vpc: default
domain: shalb.net # You need a domain in Route53
# You need a domain in Route53 account
domain: shalb.net
provisioner:
type: minikube
instanceType: m5.large
Expand Down
2 changes: 1 addition & 1 deletion bin/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ source "$PRJ_ROOT"/bin/logging.sh
function kube::deploy_apps {
INFO "Setup addons."
DEBUG "Deploy Addons via kubectl"
run_cmd "kubectl apply -f 'https://raw.githubusercontent.com/shalb/terraform-aws-minikube/master/addons/ingress.yaml'"
run_cmd "kubectl apply -f 'https://github.com/jetstack/cert-manager/releases/download/v0.13.0/cert-manager-no-webhook.yaml'"
run_cmd "kubectl apply -f 'https://raw.githubusercontent.com/shalb/terraform-aws-minikube/8a147f7c0044c318ec37990b50f0cabb205e9b44/addons/letsencrypt-prod.yaml'"
run_cmd "kubectl apply -f 'https://raw.githubusercontent.com/shalb/terraform-aws-minikube/master/addons/ingress.yaml'"
}

#######################################
Expand Down
4 changes: 2 additions & 2 deletions terraform/aws/argocd/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ resource "helm_release" "argo-cd" {
name = "argo-cd"
repository = data.helm_repository.argo.metadata[0].name
chart = "argo-cd"
version = "1.8.7"
version = "2.0.0"
namespace = "argocd"

values = [
Expand All @@ -51,7 +51,7 @@ resource "helm_release" "argo-cd" {
name = "server.certificate.domain"
value = var.argo_domain
}
set {
set {
name = "server.ingress.annotations.\"cluster\\.dev/domain\""
value = var.argo_domain
}
Expand Down
6 changes: 2 additions & 4 deletions terraform/aws/argocd/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,16 @@ server:
ingress:
enabled: true
annotations:
cert-manager.io/cluster-issuer: letsencrypt-prod
kubernetes.io/ingress.class: nginx
kubernetes.io/tls-acme: "true"
nginx.ingress.kubernetes.io/backend-protocol: HTTPS
nginx.ingress.kubernetes.io/ssl-passthrough: "true"
cluster.dev/domain: domain.shalb.net # passed with terraform
labels: {}
hosts:
- domain.cluster.dev # passed with terraform
paths:
- /
tls:
- secretName: argocd-cert
- secretName: argocd-secret
hosts:
- domain.cluster.dev # passed with terraform
config:
Expand Down

0 comments on commit 2a183ff

Please sign in to comment.