Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include full dependencies #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include full dependencies #27

wants to merge 1 commit into from

Conversation

ageorgou
Copy link
Collaborator

No description provided.

@bsipocz
Copy link
Collaborator

bsipocz commented Mar 28, 2018

I think this is an overkill for now, many of these are testing or dev requirement, and the version dependencies on packages can be more liberal.

@bsipocz
Copy link
Collaborator

bsipocz commented Mar 28, 2018

I've added extra tests for different numpy versions, etc, so we definitley can remove the version restriction from that one.

@ageorgou
Copy link
Collaborator Author

The issue was more with having an exhaustive list of dependencies - we were having problems with e.g. rasterio not being installed correctly because numpy was missing.

I agree it's not of massive importance though.

@bsipocz
Copy link
Collaborator

bsipocz commented Mar 28, 2018

hmm, but then that's an upstream rasterio issue, this really should have been dealt by pip, etc.
Anyway, if this project would go forward I suggest to package it up properly and any of these dependency issues can be dealt inside setup.py setup.cfg, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants