Merge pull request #155 from sandersky/master

Stop using _.pluck() since it doesn't work with lodash 4.x
sglanzer-deprecated · Aug 2, 2016 · 782830b · 782830b
2 parents 77e9c66 + 8c1930b
commit 782830b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/lib/reporters/json-reporter.js b/lib/reporters/json-reporter.js
@@ -7,7 +7,7 @@ var percentage = function(number, total) {
 
 
 function totalProperty(fileData, propName) {
-  return _(fileData).pluck(propName).reduce(function(memo, value) {
+  return _(fileData).map(propName).reduce(function(memo, value) {
     return memo + value;
   }, 0);
 }

diff --git a/lib/reporters/teamcity-reporter.js b/lib/reporters/teamcity-reporter.js
@@ -7,7 +7,7 @@ var percentage = function(number, total) {
 
 
 function totalProperty(fileData, propName) {
-  return _(fileData).pluck(propName).reduce(function(memo, value) {
+  return _(fileData).map(propName).reduce(function(memo, value) {
     return memo + value;
   }, 0);
 }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ember-cli-blanket",
-  "version": "0.9.7",
+  "version": "0.9.8",
   "description": "Blanket code coverage for ember-cli",
   "main": "index.js",
   "directories": {

diff --git a/tests/unit/coverage-middleware-test.js b/tests/unit/coverage-middleware-test.js
@@ -100,12 +100,12 @@ describe('coverage middleware', function() {
   });
 
   it('should instantiate all three reporters', function() {
-    var types = _.pluck(instances, 'type');
+    var types = _.map(instances, 'type');
     expect(types).to.be.eql(['TeamCityReporter', 'JsonReporter', 'LcovReporter']);
   });
 
   it('should have called report on all three reporters', function() {
-    var reportedData = _.pluck(instances, 'reported');
+    var reportedData = _.map(instances, 'reported');
     expect(reportedData).to.be.eql(['my-data', 'my-data', 'my-data']);
   });
 });