Merge pull request #70 from elwayman02/fix-renamer

Fix renamer, lcov check was not accessing the proper object
sglanzer-deprecated · Jun 11, 2015 · 651aac7 · 651aac7
2 parents 13a08aa + 92c6b75
commit 651aac7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/lib/reporters/lcov-reporter.js b/lib/reporters/lcov-reporter.js
@@ -1,13 +1,13 @@
 var Reporter = require('../reporter');
 
 var lcovRecord = function(data) {
-  var str = "",
+  var str = '',
       lineHandled = 0,
       lineFound = 0,
       fileName = data.fileName;
 
-  if(this.options.lcovOptions && this.options.lcovOptions.renamer){
-    fileName = this.options.lcovOptions.renamer(fileName);
+  if (this.options.cliOptions && this.options.cliOptions.lcovOptions && this.options.cliOptions.lcovOptions.renamer){
+    fileName = this.options.cliOptions.lcovOptions.renamer(fileName);
   }
 
   str += 'SF:' + fileName + '\n';

diff --git a/tests/unit/reporters/lcov-reporter-test.js b/tests/unit/reporters/lcov-reporter-test.js
@@ -14,9 +14,11 @@ describe('LCOV Reporter', function() {
   it('should replace modules names with file names when requested', function () {
     var expectedOutput = fs.readFileSync(path.join(__dirname, '../../fixtures/lcov-output-with-renamer.dat'), 'utf8');
     var reporter = new LCOVReporter({
-      lcovOptions: {
-        renamer: function(moduleName){
-          return moduleName.replace(/^todomvc-ember-cli/, 'something-else');
+      cliOptions: {
+        lcovOptions: {
+          renamer: function (moduleName) {
+            return moduleName.replace(/^todomvc-ember-cli/, 'something-else');
+          }
         }
       }
     });