Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from 2i2c-org:master #549

Merged
merged 2 commits into from
Dec 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions config/clusters/leap/support.values.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
nvidiaDevicePlugin:
gke:
enabled: true
version: "latest"

prometheusIngressAuthSecret:
enabled: true

Expand Down
5 changes: 0 additions & 5 deletions config/clusters/m2lines/support.values.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
nvidiaDevicePlugin:
gke:
enabled: true
version: "latest"

grafana:
grafana.ini:
server:
Expand Down
112 changes: 0 additions & 112 deletions helm-charts/support/templates/nvidiaDevicePlugin/gke/latest.yaml

This file was deleted.

112 changes: 0 additions & 112 deletions helm-charts/support/templates/nvidiaDevicePlugin/gke/stable.yaml

This file was deleted.

21 changes: 0 additions & 21 deletions helm-charts/support/values.schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ properties:
additionalProperties: false
required:
- azure
- gke
properties:
azure:
type: object
Expand All @@ -101,26 +100,6 @@ properties:
properties:
enabled:
type: boolean
gke:
type: object
additionalProperties: false
required:
- enabled
- version
properties:
enabled:
type: boolean
version:
type: string
enum:
- stable
- latest
description: |
Install the stable or latest version of nvidia GPU drivers for the node.

See table in https://cloud.google.com/kubernetes-engine/docs/how-to/gpus#installing_drivers
to determine what versions would be installed. Might need to be matched with appropriate
version of the CUDA libraries used in the images users use.

prometheusIngressAuthSecret:
type: object
Expand Down
8 changes: 2 additions & 6 deletions helm-charts/support/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -434,15 +434,11 @@ redirects:
rules: []

# Enable a daemonset to install nvidia device plugin to GPU nodes
# AWS does not require this to be set, as eksctl sets this up automatically
# Not necessary on GCP & AWS don't need this, as it is handled automatically by terraform or eksctl
# respectively
nvidiaDevicePlugin:
# For Azure-specific image, default to false
azure:
enabled: false
# For GKE specific image, defaults to false
gke:
enabled: false
version: "stable"

# Setup a separate storageClass specifically for prometheus data
prometheusStorageClass:
Expand Down
4 changes: 4 additions & 0 deletions terraform/gcp/cluster.tf
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,10 @@ resource "google_container_node_pool" "notebook" {
content {
type = each.value.gpu.type
count = each.value.gpu.count

gpu_driver_installation_config {
gpu_driver_version = "DEFAULT"
}
}

}
Expand Down
Loading