Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move check for UID 0 (i.e. root) to after the options parsing. #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Move check for UID 0 (i.e. root) to after the options parsing. #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1878e67
Move check for UID 0 (i.e. root) to after the options parsing.
iainchesworth Dec 18, 2019
6c35e72
Address review comments, specifically:
iainchesworth Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 92 additions & 48 deletions aqualinkd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <libgen.h>
#include <termios.h>
#include <signal.h>
#include <getopt.h>

#include <time.h> // Need GNU_SOURCE & XOPEN defined for strptime

Expand Down Expand Up @@ -785,6 +786,37 @@ void printHelp()
printf("\t-rsd (RS485 debug)\n");
printf("\t-rsrd (RS485 raw debug)\n");
}

// For long options that don't have a corresponding short option, the flag should
// be a value thats not part of the optstring.
//
// If one chooses a value higher than 255 then it can't possibly be a short option.

enum aqualink_option_flags
{
OPTION_FLAG_HELP = 'h',
OPTION_FLAG_NO_DAEMONIZE = 'd',
OPTION_FLAG_CONFIG_FILE = 'c',
OPTION_FLAG_DEBUG = 'v',

// Long options without a corresponding short option.
OPTION_FLAG_RSD = 0x100,
OPTION_FLAG_RSRD = 0x101
};

static const struct option aqualink_long_options[] =
{
{ "help", no_argument, NULL, OPTION_FLAG_HELP},
{ "no-daemonize", no_argument, NULL, OPTION_FLAG_NO_DAEMONIZE},
{ "config-file", required_argument, NULL, OPTION_FLAG_CONFIG_FILE},
{ "debug", no_argument, NULL, OPTION_FLAG_DEBUG},
{ "rsd", no_argument, NULL, OPTION_FLAG_RSD},
{ "rsrd", no_argument, NULL, OPTION_FLAG_RSRD},
{0, 0, 0, 0}
};

static char* aqualink_short_options = "hdc:v";

int main(int argc, char *argv[])
{
// main_loop ();
Expand All @@ -797,60 +829,68 @@ int main(int argc, char *argv[])
bool cmdln_debugRS485 = false;
bool cmdln_lograwRS485 = false;

if (argc > 1 && strcmp(argv[1], "-h") == 0)
{
printHelp();
return 0;
}

// struct lws_context_creation_info info;
// Log only NOTICE messages and above. Debug and info messages
// will not be logged to syslog.
setlogmask(LOG_UPTO(LOG_NOTICE));

if (getuid() != 0)
{
//logMessage(LOG_ERR, "%s Can only be run as root\n", argv[0]);
fprintf(stderr, "ERROR %s Can only be run as root\n", argv[0]);
return EXIT_FAILURE;
}

// Initialize the daemon's parameters.
init_parameters(&_config_parameters);
cfgFile = defaultCfg;
//sprintf(cfgFile, "%s", DEFAULT_CONFIG_FILE);

for (i = 1; i < argc; i++)
int ch = 0;

while ((ch = getopt_long(argc, argv, aqualink_short_options, aqualink_long_options, NULL)) != -1)
{
if (strcmp(argv[i], "-h") == 0)
{
printHelp();
return 0;
}
if (strcmp(argv[i], "-d") == 0)
{
_config_parameters.deamonize = false;
}
else if (strcmp(argv[i], "-c") == 0)
{
cfgFile = argv[++i];
}
else if (strcmp(argv[i], "-vv") == 0)
{
cmdln_loglevel = LOG_DEBUG_SERIAL;
}
else if (strcmp(argv[i], "-v") == 0)
{
cmdln_loglevel = LOG_DEBUG;
}
else if (strcmp(argv[i], "-rsd") == 0)
{
cmdln_debugRS485 = true;
}
else if (strcmp(argv[i], "-rsrd") == 0)
{
cmdln_lograwRS485 = true;
}
// check to see if a single character or long option came through
switch (ch)
{
case OPTION_FLAG_NO_DAEMONIZE: // short option 'd' / long option "no-daemonize"
_config_parameters.deamonize = false;
break;

case OPTION_FLAG_CONFIG_FILE: // short option 'c' / long option "config-file"
cfgFile = optarg;
break;

case OPTION_FLAG_DEBUG: // short option 'v' / long option "debug"
if (LOG_DEBUG_SERIAL == cmdln_loglevel)
{
// Already at the highest level of debug logging...do nothing.
logMessage(LOG_DEBUG, "Already at highest level of debugging...don't need to specify more verbosity");
}
else if (LOG_DEBUG == cmdln_loglevel)
{
// There has been more than one "-v" option so increment the logging level.
cmdln_loglevel = LOG_DEBUG_SERIAL;
}
else
{
cmdln_loglevel = LOG_DEBUG;
}
break;

case OPTION_FLAG_RSD: // long option "rsd"
cmdln_debugRS485 = true;
break;

case OPTION_FLAG_RSRD: // long option "rsrd"
cmdln_lograwRS485 = true;
break;

case OPTION_FLAG_HELP: // short option 'h' / long option "help"
default: // any unknown options
printHelp();
return EXIT_SUCCESS;;
}
}

if (getuid() != 0)
{
//logMessage(LOG_ERR, "%s Can only be run as root\n", argv[0]);
fprintf(stderr, "ERROR %s Can only be run as root\n", argv[0]);
return EXIT_FAILURE;
}

initButtons(&_aqualink_data);
Expand All @@ -867,10 +907,14 @@ int main(int argc, char *argv[])
_config_parameters.log_raw_RS_bytes = true;


if (_config_parameters.display_warnings_web == true)
setLoggingPrms(_config_parameters.log_level, _config_parameters.deamonize, _config_parameters.log_file, _aqualink_data.last_display_message);
else
setLoggingPrms(_config_parameters.log_level, _config_parameters.deamonize, _config_parameters.log_file, NULL);
if (_config_parameters.display_warnings_web == true)
{
setLoggingPrms(_config_parameters.log_level, _config_parameters.deamonize, _config_parameters.log_file, _aqualink_data.last_display_message);
}
else
{
setLoggingPrms(_config_parameters.log_level, _config_parameters.deamonize, _config_parameters.log_file, NULL);
}

logMessage(LOG_NOTICE, "%s v%s\n", AQUALINKD_NAME, AQUALINKD_VERSION);

Expand Down Expand Up @@ -950,7 +994,7 @@ int main(int argc, char *argv[])
main_loop();
}

exit(EXIT_SUCCESS);
return EXIT_SUCCESS;
}

/*
Expand Down