Merge pull request prometheus#31 from promlabs/feature/negative-offset

support negative offset
sfc-gh-pkommini · Mar 24, 2021 · 81dd0a3 · 81dd0a3
2 parents f15df99 + df7754c
commit 81dd0a3
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/promql.grammar b/src/promql.grammar
@@ -185,7 +185,7 @@ ParenExpr {
 }
 
 OffsetExpr {
-  Expr Offset Duration
+  Expr Offset Sub? Duration
 }
 
 MatrixSelector {

diff --git a/test/expression.txt b/test/expression.txt
@@ -777,3 +777,24 @@ Inf{foo="bar"}
 
 ==>
 PromQL(Expr(BinaryExpr(Expr(NumberLiteral),⚠,BinModifiers,Expr(VectorSelector(LabelMatchers(LabelMatchList(LabelMatcher(LabelName,MatchOp(EqlSingle),StringLiteral))))))))
+
+# Negative offset
+
+foo offset -5d
+
+==>
+PromQL(Expr(OffsetExpr(Expr(VectorSelector(MetricIdentifier(Identifier))), Offset, Sub, Duration)))
+
+# Negative offset with space
+
+foo offset - 5d
+
+==>
+PromQL(Expr(OffsetExpr(Expr(VectorSelector(MetricIdentifier(Identifier))), Offset, Sub, Duration)))
+
+# Positive offset
+
+foo offset 5d
+
+==>
+PromQL(Expr(OffsetExpr(Expr(VectorSelector(MetricIdentifier(Identifier))), Offset, Duration)))