Add support for overriding server name #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also interested on this, any chance we can get this merged & released @sfackler ? |
sfackler
reviewed
Apr 5, 2023
| /// verify that server certificate includes this value. | ||
| /// | ||
| /// If this function is called, provided `server_name` will be used instead, | ||
| /// and URL will not affect certificate veritication. |
There was a problem hiding this comment.
This should document that it'll also be sent out in the SNI extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original case: kube-rs/kube#991
This PR adds setting
server_namewhich can be explicitly configured by user. When this setting is set, it is passed as-is to openssl instead of parsing URL.