Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the code based on the serum-ts #105

Open
wants to merge 26 commits into
base: alpha
Choose a base branch
from

Conversation

dpguoming
Copy link

  • update the code based on the serum-ts
    • add new instruction type: prune, consume_envents_permision
    • add market layout version: v1, v2, v3
    • add open orders layout version: v1, v2
    • add queue header layout, event queue header layout, event flags layout
    • update instructions initialize parameters
    • update decode instruction parse functions
    • add market serum discount
  • test code for part of new features
  • code format

@dpguoming dpguoming changed the title Gm branch update the code based on the serum-ts Jan 24, 2022
@michaelhly
Copy link
Contributor

@dpguoming sorry for the delay. Would you mind fixing the lint issues?

@leofisG
Copy link
Contributor

leofisG commented Mar 13, 2022

Do you mind fixing the linter : )

@adrida
Copy link

adrida commented Jun 25, 2022

Hi, when is the merge of this PR scheduled?

@leofisG
Copy link
Contributor

leofisG commented Jun 25, 2022

CI is not passing

@adrida
Copy link

adrida commented Jun 27, 2022

Hi guys,

Just a quick question. I tried to use pyserum to automate some trades but the queries are very slow (especially to get open orders). I used my own private rpc and it still took some time to interact with serum (up to 15 sec) where with solana the interaction are way quicker.

I was wondering if the problem came from the layer added by pyserum or is serum slow by nature?

Thanks for your time

@leofisG
Copy link
Contributor

leofisG commented Jun 27, 2022 via email

@adrida
Copy link

adrida commented Jun 27, 2022

Querying Serum data is slow. Try talk to your RPC Provider and see if there
are able to optimize the query time.

adrida @.***> 于2022年6月27日周一 05:01写道:

Hi guys,

Just a quick question. I tried to use pyserum to automate some trades but
the queries are very slow (especially to get open orders). I used my own
private rpc and it still took some time to interact with serum (up to 15
sec) where with solana the interaction are way quicker.

I was wondering if the problem came from the layer added by pyserum or is
serum slow by nature?

Thanks for your time


Reply to this email directly, view it on GitHub
#105 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMFDUJNWXTLWBSDQCVWYATVRFUWJANCNFSM5MU5UDFQ
.
You are receiving this because you commented.Message ID:
@.***>

--
Wang (Leonard) Ge
Imperial College London 2021
@.***
+44 - 079-364-72284

I understand, thanks a lot! Maybe there is a way to bypass serum and talk directly to the smart contract? Can people really do automated trading on serum markets with dozens of seconds in delay to get the data?

@dpguoming
Copy link
Author

CI is not passing

I tried a few times to pass CI, but it might be some different between auto-execute with my environment. Would you mind to assist it, I have opened the permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants