Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with UPath #33

Closed

Conversation

remi-braun
Copy link
Member

@remi-braun remi-braun commented Dec 13, 2024

Add the support to UPath in sertit utils.
For now, keep also the support of cloudpathlib.

This is only a proof of concept, wait further updates of upath to use it, as its maturity is still debatable.

@remi-braun remi-braun linked an issue Dec 13, 2024 that may be closed by this pull request
2 tasks
@remi-braun
Copy link
Member Author

Not bad for a first draft:

2024-12-13_11h18_02

@remi-braun
Copy link
Member Author

Fewer tests are now failing:
2024-12-13_11h58_40

Note: test_s3 and test_unistra are still testing against cloudpathlib

@remi-braun
Copy link
Member Author

Closer...
2024-12-13_12h32_37

@remi-braun
Copy link
Member Author

OMGGGG
image

@remi-braun
Copy link
Member Author

UPath is really faster than cloudpathlib (all tests done in 1'26" compared to 2'12" with cloudpathlib)

@remi-braun
Copy link
Member Author

Merged into 2.0.0 rather than main

@remi-braun remi-braun closed this Dec 13, 2024
@remi-braun remi-braun deleted the 4-switch-from-cloudpathlib-to-universal_pathlib branch December 13, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from cloudpathlib to universal_pathlib
1 participant