Merge pull request #6 from serpent-os/atomic-index-write

indexer: Write index atomically using `rename`
serpent-os · Sep 13, 2024 · c71e92a · c71e92a
2 parents 7d0973a + 7ca36be
commit c71e92a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/source/vessel/indexer.d b/source/vessel/indexer.d
@@ -21,7 +21,7 @@ import moss.format.binary.payload;
 import moss.format.binary.payload.meta;
 import moss.format.binary.writer;
 import std.algorithm : multiSort;
-import std.file : exists, mkdirRecurse;
+import std.file : exists, mkdirRecurse, rename;
 import std.path : buildPath, dirName, relativePath;
 import vessel.collectiondb;
 import vibe.d;
@@ -64,7 +64,8 @@ public final class Indexer
 
         auto records = collectionDB.volatileRecords();
         records.multiSort!((a, b) => a.sourceID < b.sourceID, (a, b) => a.name < b.name);
-        auto fi = File(outputFilename, "wb");
+        immutable string tmpIndexFile = outputFilename ~ ".tmp";
+        auto fi = File(tmpIndexFile, "wb");
         auto wr = new Writer(fi);
         wr.fileType = MossFileType.Repository;
         wr.compressionType = PayloadCompression.Zstd;
@@ -104,6 +105,8 @@ public final class Indexer
             wr.addPayload(mp);
         }
         wr.close();
+        /* rename is guaranteed to be atomic */
+        tmpIndexFile.rename(outputFilename);
     }
 
 private: