Skip to content

moss/boulder: Add support for font providers

Sign in for the full log view
GitHub Actions / clippy failed Aug 13, 2024 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (3)

crates/triggers/src/format.rs|77 col 17| warning: mutable key type
--> crates/triggers/src/format.rs:77:17
|
77 | #[derive(Debug, Deserialize)]
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type
= note: #[warn(clippy::mutable_key_type)] on by default
= note: this warning originates in the derive macro Deserialize (in Nightly builds, run with -Z macro-backtrace for more info)
boulder/src/package/analysis/handler.rs|142 col 8| warning: this boolean expression can be simplified
--> boulder/src/package/analysis/handler.rs:142:8
|
142 | if !info.target_path.starts_with("/usr/share/font")
| ^
143 | | && !(info.file_name().ends_with(".ttf") || info.file_name().ends_with(".otf"))
| |
______________________________________________________________________________^ help: try: !(info.target_path.starts_with("/usr/share/font") || info.file_name().ends_with(".ttf") || info.file_name().ends_with(".otf"))
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
= note: #[warn(clippy::nonminimal_bool)] on by default
boulder/src/package/analysis/handler.rs|153 col 10| warning: this .into_iter() call is equivalent to .iter() and will not consume the slice
--> boulder/src/package/analysis/handler.rs:153:10
|
153 | .into_iter()
| ^^^^^^^^^ help: call directly: iter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: #[warn(clippy::into_iter_on_ref)] on by default

Filtered Findings (0)

Annotations

Check warning on line 77 in crates/triggers/src/format.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] crates/triggers/src/format.rs#L77

warning: mutable key type
  --> crates/triggers/src/format.rs:77:17
   |
77 | #[derive(Debug, Deserialize)]
   |                 ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type
   = note: `#[warn(clippy::mutable_key_type)]` on by default
   = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
Raw output
crates/triggers/src/format.rs:77:17:w:warning: mutable key type
  --> crates/triggers/src/format.rs:77:17
   |
77 | #[derive(Debug, Deserialize)]
   |                 ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type
   = note: `#[warn(clippy::mutable_key_type)]` on by default
   = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)


__END__

Check warning on line 142 in boulder/src/package/analysis/handler.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] boulder/src/package/analysis/handler.rs#L142

warning: this boolean expression can be simplified
   --> boulder/src/package/analysis/handler.rs:142:8
    |
142 |       if !info.target_path.starts_with("/usr/share/font")
    |  ________^
143 | |         && !(info.file_name().ends_with(".ttf") || info.file_name().ends_with(".otf"))
    | |______________________________________________________________________________________^ help: try: `!(info.target_path.starts_with("/usr/share/font") || info.file_name().ends_with(".ttf") || info.file_name().ends_with(".otf"))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
    = note: `#[warn(clippy::nonminimal_bool)]` on by default
Raw output
boulder/src/package/analysis/handler.rs:142:8:w:warning: this boolean expression can be simplified
   --> boulder/src/package/analysis/handler.rs:142:8
    |
142 |       if !info.target_path.starts_with("/usr/share/font")
    |  ________^
143 | |         && !(info.file_name().ends_with(".ttf") || info.file_name().ends_with(".otf"))
    | |______________________________________________________________________________________^ help: try: `!(info.target_path.starts_with("/usr/share/font") || info.file_name().ends_with(".ttf") || info.file_name().ends_with(".otf"))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
    = note: `#[warn(clippy::nonminimal_bool)]` on by default


__END__

Check warning on line 153 in boulder/src/package/analysis/handler.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] boulder/src/package/analysis/handler.rs#L153

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
   --> boulder/src/package/analysis/handler.rs:153:10
    |
153 |         .into_iter()
    |          ^^^^^^^^^ help: call directly: `iter`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
    = note: `#[warn(clippy::into_iter_on_ref)]` on by default
Raw output
boulder/src/package/analysis/handler.rs:153:10:w:warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
   --> boulder/src/package/analysis/handler.rs:153:10
    |
153 |         .into_iter()
    |          ^^^^^^^^^ help: call directly: `iter`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
    = note: `#[warn(clippy::into_iter_on_ref)]` on by default


__END__