Make crates/triggers API suitable for usysconf #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livingsilver94
force-pushed
the
fnmatch-filesystem
branch
from
d0ea498
to
e0d17e4
Compare
ermo
added
status: help wanted
|
I think we should review (and hopefully accept) this PR before moving to usysconf. This PR in fact is the core API for both moss and usysconf. If there's something fishy here, there's something fishy everywhere. |
livingsilver94
force-pushed
the
fnmatch-filesystem
branch
from
e0d17e4
to
35048d2
Compare
livingsilver94
force-pushed
the
fnmatch-simplify
branch
from
d9402b8
to
03d9ce9
Compare
livingsilver94
force-pushed
the
fnmatch-filesystem
branch
from
35048d2
to
f510a50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to decouple the current crates/triggers code, which was written specifically with moss in mind, to make it as generic as possible. Particularly, we want to re-write Solus' usysconf tool in Rust, leveraging the Serpent OS tech stack. usysconf works differently from "moss-triggers", yet we want to share as much code as possible. See this message for reference: serpent-os/usysconf-rs#1 (comment)
NOTE: This PR sits on top of #191 and in fact pours its commit in the fnmatch-simplify branch. This is for simplicity, so that every PR only sees its relevant subset of commits. We'll eventually merge fn-simplify into main.