nitpickery - status code >= 500 consistency in names/comments

serilog-web · Apr 20, 2020 · 58cde3a · 58cde3a
1 parent c4ae636
commit 58cde3a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/SerilogWeb.Classic/Classic/ApplicationLifecycleModule.cs b/src/SerilogWeb.Classic/Classic/ApplicationLifecycleModule.cs
@@ -86,7 +86,7 @@ public static Func<HttpContextBase, bool> RequestFilter
         /// <summary>
         /// When set to Always, form data will be written via an event (using
         /// severity from FormDataLoggingLevel).  When set to OnlyOnError, this
-        /// will only be written if the Response has a 500 status.
+        /// will only be written if the Response has status code >= 500.
         /// When set to OnMatch <see cref="ShouldLogPostedFormData"/>
         /// is executed to determine if form data is logged.
         /// The default is Never. Requires that <see cref="IsEnabled"/> is also

diff --git a/src/SerilogWeb.Classic/Classic/SerilogWebClassicConfigurationBuilder.cs b/src/SerilogWeb.Classic/Classic/SerilogWebClassicConfigurationBuilder.cs
@@ -210,7 +210,7 @@ public FormDataLoggingConfigurationBuilder AtLevel(LogEventLevel level)
             }
 
             /// <summary>
-            /// Specify that FormData should be attached to logged events only in case of error (Status > 500)
+            /// Specify that FormData should be attached to logged events only in case of error (status code >= 500)
             /// </summary>
             /// <returns>A configuration object to allow chaining</returns>
             public FormDataLoggingConfigurationBuilder OnlyOnError()
@@ -221,7 +221,7 @@ public FormDataLoggingConfigurationBuilder OnlyOnError()
             }
 
             /// <summary>
-            /// Specify that FormData should be attached to logged events only when the provided condistion is true
+            /// Specify that FormData should be attached to logged events only when the provided condition is true
             /// </summary>
             /// <param name="matchingFunction">The predicate that defines when FormData should be attached</param>
             /// <returns>A configuration object to allow chaining</returns>

diff --git a/test/SerilogWeb.Classic.Tests/ModuleConfigurationContractTests.cs b/test/SerilogWeb.Classic.Tests/ModuleConfigurationContractTests.cs
@@ -396,7 +396,7 @@ public void RequestFiltering()
         [InlineData(500, true)]
         [InlineData(501, true)]
         [InlineData(499, false)]
-        public void StatusCodeBiggerThan500AreLoggedAsError(int httpStatusCode, bool isLoggedAsError)
+        public void StatusCodeEqualOrBiggerThan500AreLoggedAsError(int httpStatusCode, bool isLoggedAsError)
         {
             TestContext.SimulateRequest(httpStatusCode: httpStatusCode);
 

diff --git a/test/SerilogWeb.Classic.Tests/WebRequestLoggingHandlerTests.cs b/test/SerilogWeb.Classic.Tests/WebRequestLoggingHandlerTests.cs
@@ -452,7 +452,7 @@ public void RequestFiltering()
         [InlineData(500, true)]
         [InlineData(501, true)]
         [InlineData(499, false)]
-        public void StatusCodeBiggerThan500AreLoggedAsError(int httpStatusCode, bool isLoggedAsError)
+        public void StatusCodeEqualOrBiggerThan500AreLoggedAsError(int httpStatusCode, bool isLoggedAsError)
         {
             TestContext.SimulateRequest(httpStatusCode: httpStatusCode);