Get rid of autoref-specialisation #320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GnomedDev
force-pushed
the
delete-autoref-hacks
branch
from
f21e233
to
4c86c19
Compare
This was referenced Nov 1, 2024
GnomedDev
force-pushed
the
next
branch
2 times, most recently
from
b8ce188
to
ea082eb
Compare
GnomedDev
force-pushed
the
delete-autoref-hacks
branch
from
4c86c19
to
4866c24
Compare
GnomedDev
force-pushed
the
delete-autoref-hacks
branch
from
4866c24
to
53f2e5a
Compare
This was referenced Nov 20, 2024
GnomedDev
force-pushed
the
delete-autoref-hacks
branch
from
53f2e5a
to
cce8cc6
Compare
GnomedDev
force-pushed
the
delete-autoref-hacks
branch
from
cce8cc6
to
ba14a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly simplifies poise internals, by removing the fancy autoderef specialization used to fallback from the poise traits, to the serenity traits, and finally to FromStr.
It is replaced by normal implementations, which does not significantly impact usability as users may define newtypes to implement the traits themselves if needed.
This PR is currently missing: