Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TCP keep-alive in Monero RPC #497

Closed
wants to merge 2 commits into from
Closed

Conversation

kayabaNerve
Copy link
Member

May resolve the prior observed spontaneous errors, with the retry code moved to just the authentication-stale case to check.

If this doesn't work, this should still be merged with the retry code as originally placed.

May resolve the prior observed spontaneous errors, with the retry code moved to
just the authentication-stale case to check.

If this doesn't work, this should still be merged with the retry code as
originally placed.
@kayabaNerve kayabaNerve added improvement This could be better monero An issue with the Monero library/integration labels Dec 21, 2023
@kayabaNerve
Copy link
Member Author

kayabaNerve commented Dec 21, 2023

This PR messed up and did not set keep-alive as expected. It just calls set keep-alive, yet does in a way turning it off (as it already should be).

Despite this, the CI passes for the above two runs when it was prior too erratic to survive one?? Did we update some patch making this no longer needed? Is keep-alive not already off and that was the issue?

It can't be only retrying on stale auth is enough. The prior code which retried on any error still occasionally caused failures (just with acceptably low probability).

We also now wrap a connector instead of having hyper-rustls provide the connector. The provided connector has enforce_scheme set to false, which we don't touch. That could be it? Except the experiment with boring-ssl reproduced this error (suggesting its agnostic to the TLS layer used).

Or keep-alive is on-by-default yet breaks things here, or the above two runs are a statistical fluke. I have no idea.

@kayabaNerve kayabaNerve closed this Jan 1, 2024
@kayabaNerve kayabaNerve deleted the request-keep-alive branch January 1, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This could be better monero An issue with the Monero library/integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant